Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector.patch and Vector.++ should not consume linear time for large Vectors #10001

Closed
scabug opened this issue Oct 20, 2016 · 4 comments
Closed

Vector.patch and Vector.++ should not consume linear time for large Vectors #10001

scabug opened this issue Oct 20, 2016 · 4 comments
Labels
duplicate performance

Comments

@scabug
Copy link

scabug commented Oct 20, 2016

Vectors are trees when the size is big. They deserved O(log n) concatenation and splitting.
@scabug
Copy link
Author

scabug commented Oct 20, 2016

Imported From: https://issues.scala-lang.org/browse/SI-10001?orig=1
Reporter: @Atry
See #4442

@scabug
Copy link
Author

scabug commented Oct 20, 2016

@SethTisue said:
duplicate of #4442

@scabug scabug closed this as completed Oct 20, 2016
@scabug
Copy link
Author

scabug commented Oct 21, 2016

@Atry said (edited on Oct 21, 2016 1:44:28 AM UTC):
This issue is not an exact duplicate.

Vector.patch may be tracked here.

@scabug
Copy link
Author

scabug commented Oct 21, 2016

@SethTisue said:
I'd suggest simply adding a comment on the other ticket that when Vector.++ is tackled, we should make sure Vector.patch gets the benefit, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scabug