Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PartiallyOrdered a universal trait #10128

Closed
scabug opened this issue Dec 30, 2016 · 5 comments · Fixed by scala/scala#7085
Closed

Make PartiallyOrdered a universal trait #10128

scabug opened this issue Dec 30, 2016 · 5 comments · Fixed by scala/scala#7085
Assignees
@xuwei-k
Labels
enhancement has PR help wanted
Milestone
2.13.0-M5

Comments

@scabug
Copy link

scabug commented Dec 30, 2016 •
edited by retronym

PartiallyOrdered is a non-universal trait, though it seems like it could be made one "for free".

I ran into this while trying to make a value-class that extends PartiallyOrdered.
@scabug
Copy link
Author

scabug commented Dec 30, 2016

Imported From: https://issues.scala-lang.org/browse/SI-10128?orig=1
Reporter: Ryan Williams (rdub)
Affected Versions: 2.12.1

@scabug
Copy link
Author

scabug commented Dec 30, 2016

Ryan Williams (rdub) said:
I ported PartiallyOrdered to org.hammerlab:iterator (mvn central link) and made it extend Any as a work-around.

I just tried to open the scala repo to send a PR but the IntelliJ scala plugin threw errors trying to load it, will look in to filing that elsewhere ¯\(ツ)/¯

@scabug
Copy link
Author

scabug commented Jan 10, 2017

@SethTisue said:
re: IntelliJ, see src/intellij/README.md. it should work, a lot of scala/scala work happens in IntelliJ

@scabug scabug added this to the Backlog milestone Apr 7, 2017
@atiqsayyed
Copy link

I wanna pick this one, is there anything that i should know apart form obvious comments above??..

@SethTisue
Copy link
Member

I suspect a fix would need to target 2.13.x because of binary compatibility

@xuwei-k xuwei-k mentioned this issue Aug 16, 2018
Merged
@xuwei-k xuwei-k added the has PR label Aug 16, 2018
@SethTisue SethTisue modified the milestones: Backlog, 2.13.0-M5 Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuwei-k xuwei-k

Labels
enhancement has PR help wanted
Projects
None yet
Milestone
2.13.0-M5
Development

Successfully merging a pull request may close this issue.

Make PartiallyOrdered a universal trait xuwei-k/scala-1
4 participants
@SethTisue @xuwei-k @atiqsayyed @scabug