Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests need to account for variance #3051

Closed
scabug opened this issue Feb 11, 2010 · 3 comments
Closed

manifests need to account for variance #3051

scabug opened this issue Feb 11, 2010 · 3 comments

Comments

@scabug
Copy link

scabug commented Feb 11, 2010

Gilles, am opening this ticket for you since it came up in email between martin and me and we didn't want it to slip through the cracks. I am willing to implement it if you like but I could use a sketch of how you think I ought to go about it.

ClassManifest.scala:

    def subargs(args1: List[OptManifest[_]], args2: List[OptManifest[_]]): Boolean = {
      (args1 zip args2) forall { 
        case (x: ClassManifest[_], y: ClassManifest[_]) => x <:< y // !!! [Martin] this is wrong, need to take variance into account
        case (NoManifest, NoManifest) => true
        case _ => false
      }
    }
@scabug
Copy link
Author

scabug commented Feb 11, 2010

Imported From: https://issues.scala-lang.org/browse/SI-3051?orig=1
Reporter: @paulp

@scabug
Copy link
Author

scabug commented May 25, 2012

@xeno-by said:
Scala 2.10.0-M3 includes type tags (which may be renamed by the time 2.10.0-final hits). Type tags are thin wrappers over compiler's Types, which means that they support all intricacies of Scala's type system.

Type tags are now a recommended way to reify types, and manifests are deprecated. Hence we won't invest into fixing bugs in manifests, especially such deep as this one.

@scabug scabug closed this as completed May 25, 2012
@scabug
Copy link
Author

scabug commented Feb 2, 2015

Malcolm Greaves (malcolmgreaves) said:
There's a glaring fault with TypeTags in 2.10 though: they are not threadsafe. This makes them useless for nearly any production system. Are TypeTags going to be fixed on 2.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant