Scala Programming Language
  1. Scala Programming Language
  2. SI-4860

Remove deprecated methods which are scheduled for removal for 2.10

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Misc Library
    • Labels:
      None

      Description

      Remove the methods marked with @deprecated with `since` argument < 2.9 for the 2.10 release.

      Because of the huge amount of removals this time it would make sense to do it early, so that people can start complaining early, too.

      1. tests
        168 kB
        Simon Ochsenreither

        Activity

        Hide
        Simon Ochsenreither added a comment - - edited

        Pull request: https://github.com/scala/scala/pull/64

        Notable things:

        • The top-level offenders scala.Cell, scala.CountedIterator and scala.NotDefinedError are finally gone.
        • Cleanup in the scala package object (Tuples), Product and Function.
        • The collection library is considerably cleaner.
        • scala.Math is gone, scala.MathCommon is consolidated into the scala.math package object.
        • Failing tests were adapted, all tests pass.

        The case of methods of one class overriding deprecated methods of another class without @deprecated appeared three times:

        1.: findIndexOf
        Deprecated in SeqLike [0], overridden in SeqProxyLike [1], SeqForwarder [2] without @deprecated.
        => Removed

        2.: +
        Deprecated in BufferLike [3], overridden in SynchronizedBuffer [4] without @depecated.
        => Removed

        3.: size_=
        UIElement's size_= [5] is deprecated, but overridden in Window [6].
        I'm not sure what's intended:

        • remove the method from Window, too
        • remove just the override modifier
          => Kept (after asking on #scala)

        [0] https://github.com/scala/scala/blob/master/src/library/scala/collection/SeqLike.scala#L124

        [1] https://github.com/scala/scala/blob/master/src/library/scala/collection/SeqProxyLike.scala#L36

        [2] https://github.com/scala/scala/blob/master/src/library/scala/collection/generic/SeqForwarder.scala#L38

        [3] https://github.com/scala/scala/blob/master/src/library/scala/collection/mutable/BufferLike.scala#L243

        [4] https://github.com/scala/scala/blob/master/src/library/scala/collection/mutable/SynchronizedBuffer.scala#L48

        [5] https://github.com/scala/scala/blob/master/src/swing/scala/swing/UIElement.scala#L101

        [6] https://github.com/scala/scala/blob/master/src/swing/scala/swing/Window.scala#L56

        Show
        Simon Ochsenreither added a comment - - edited Pull request: https://github.com/scala/scala/pull/64 Notable things: The top-level offenders scala.Cell, scala.CountedIterator and scala.NotDefinedError are finally gone. Cleanup in the scala package object (Tuples), Product and Function. The collection library is considerably cleaner. scala.Math is gone, scala.MathCommon is consolidated into the scala.math package object. Failing tests were adapted, all tests pass. The case of methods of one class overriding deprecated methods of another class without @deprecated appeared three times: 1.: findIndexOf Deprecated in SeqLike [0] , overridden in SeqProxyLike [1] , SeqForwarder [2] without @deprecated. => Removed 2.: + Deprecated in BufferLike [3] , overridden in SynchronizedBuffer [4] without @depecated. => Removed 3.: size_= UIElement's size_= [5] is deprecated, but overridden in Window [6] . I'm not sure what's intended: remove the method from Window, too remove just the override modifier => Kept (after asking on #scala) [0] https://github.com/scala/scala/blob/master/src/library/scala/collection/SeqLike.scala#L124 [1] https://github.com/scala/scala/blob/master/src/library/scala/collection/SeqProxyLike.scala#L36 [2] https://github.com/scala/scala/blob/master/src/library/scala/collection/generic/SeqForwarder.scala#L38 [3] https://github.com/scala/scala/blob/master/src/library/scala/collection/mutable/BufferLike.scala#L243 [4] https://github.com/scala/scala/blob/master/src/library/scala/collection/mutable/SynchronizedBuffer.scala#L48 [5] https://github.com/scala/scala/blob/master/src/swing/scala/swing/UIElement.scala#L101 [6] https://github.com/scala/scala/blob/master/src/swing/scala/swing/Window.scala#L56
        Hide
        Commit Message Bot added a comment -

        (extempore in r25511) Removing the code which has been deprecated since 2.8.0. Contributed by
        Simon Ochsenreither, although deleting code is such fun one hesitates to
        call it a contribution. Still, we will. Closes SI-4860, no review.

        Show
        Commit Message Bot added a comment - (extempore in r25511 ) Removing the code which has been deprecated since 2.8.0. Contributed by Simon Ochsenreither, although deleting code is such fun one hesitates to call it a contribution. Still, we will. Closes SI-4860 , no review.

          People

          • Assignee:
            Paul Phillips
            Reporter:
            Simon Ochsenreither
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development