Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reify code that returns an object of a locally defined type #5334

Closed
scabug opened this issue Dec 23, 2011 · 4 comments
Closed

Cannot reify code that returns an object of a locally defined type #5334

scabug opened this issue Dec 23, 2011 · 4 comments
Assignees
Milestone

Comments

@scabug
Copy link

scabug commented Dec 23, 2011

import scala.tools.nsc.reporters._
import scala.tools.nsc.Settings
import reflect.runtime.Mirror.ToolBox

object Test extends App {
  val code = scala.reflect.Code.lift{
    class C
    new C
  };

  val reporter = new ConsoleReporter(new Settings)
  val toolbox = new ToolBox(reporter)
  val ttree = toolbox.typeCheck(code.tree)
  toolbox.runExpr(ttree)
}
java.lang.ClassNotFoundException: Test.code $C
  at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
  at java.security.AccessController.doPrivileged(Native Method)
  at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
  at scala.tools.nsc.util.ScalaClassLoader$URLClassLoader.scala$tools$nsc$util$ScalaClassLoader$$super$findClass(ScalaClassLoader.scala:159)
  at scala.tools.nsc.util.ScalaClassLoader$class.findClass(ScalaClassLoader.scala:57)
  at scala.tools.nsc.util.ScalaClassLoader$URLClassLoader.findClass(ScalaClassLoader.scala:159)
  at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
  at scala.tools.nsc.util.ScalaClassLoader$URLClassLoader.scala$tools$nsc$util$ScalaClassLoader$$super$loadClass(ScalaClassLoader.scala:159)
  at scala.tools.nsc.util.ScalaClassLoader$class.loadClass(ScalaClassLoader.scala:63)
  at scala.tools.nsc.util.ScalaClassLoader$URLClassLoader.loadClass(ScalaClassLoader.scala:159)
  at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
  at Test$delayedInit$body.apply(reify_anonymous.scala:6)
  at scala.Function0$class.apply$mcV$sp(Function0.scala:34)
  at scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12)
  at scala.App$$anonfun$main$1.apply(App.scala:61)
  at scala.App$$anonfun$main$1.apply(App.scala:61)
  at scala.collection.LinearSeqOptimized$class.foreach(LinearSeqOptimized.scala:59)
  at scala.collection.immutable.List.foreach(List.scala:76)
  at scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:31)
  at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:44)
  at scala.App$class.main(App.scala:61)
  at Test$.main(reify_anonymous.scala:5)
  at Test.main(reify_anonymous.scala)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:597)
  at scala.tools.nsc.util.ScalaClassLoader$$anonfun$run$1.apply(ScalaClassLoader.scala:90)
  at scala.tools.nsc.util.ScalaClassLoader$class.asContext(ScalaClassLoader.scala:38)
  at scala.tools.nsc.util.ScalaClassLoader$URLClassLoader.asContext(ScalaClassLoader.scala:159)
  at scala.tools.nsc.util.ScalaClassLoader$class.run(ScalaClassLoader.scala:90)
  at scala.tools.nsc.util.ScalaClassLoader$URLClassLoader.run(ScalaClassLoader.scala:159)
  at scala.tools.nsc.CommonRunner$class.run(ObjectRunner.scala:28)
  at scala.tools.nsc.ObjectRunner$.run(ObjectRunner.scala:45)
  at scala.tools.nsc.CommonRunner$class.runAndCatch(ObjectRunner.scala:35)
  at scala.tools.nsc.ObjectRunner$.runAndCatch(ObjectRunner.scala:45)
  at scala.tools.nsc.MainGenericRunner.runTarget$1(MainGenericRunner.scala:70)
  at scala.tools.nsc.MainGenericRunner.process(MainGenericRunner.scala:92)
  at scala.tools.nsc.MainGenericRunner$.main(MainGenericRunner.scala:101)
  at scala.tools.nsc.MainGenericRunner.main(MainGenericRunner.scala)
@scabug
Copy link
Author

scabug commented Dec 23, 2011

Imported From: https://issues.scala-lang.org/browse/SI-5334?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0
Other Milestones: 2.10.0

@scabug
Copy link
Author

scabug commented Dec 23, 2011

@xeno-by said:

def codify(tree: Tree): Tree = debugTrace("codified " + tree + " -> ") {
  val targetType = definitions.CodeClass.primaryConstructor.info.paramTypes.head
  val reifier = new Reifier()
  val arg = gen.mkAsInstanceOf(reifier.reifyTopLevel(tree), targetType, wrapInApply = false)
  val treetpe = // this really should use packedType(tree.tpe, context.owner) 
                // where packedType is defined in Typers. But we can do that only if liftCode is moved to Typers.
    if (tree.tpe.typeSymbol.isAnonymousClass) tree.tpe.typeSymbol.classBound
    else tree.tpe
  New(TypeTree(appliedType(definitions.CodeClass.typeConstructor, List(treetpe.widen))),
    List(List(arg)))
}

The comment says it all. Bugfix is postponed until liftcode becomes a macro (and, consequently, gets moved to Typers).

@scabug
Copy link
Author

scabug commented Dec 23, 2011

@xeno-by said:
Tests have been submitted as a pull request to scala/scala: scala/scala#74

@scabug
Copy link
Author

scabug commented Feb 6, 2012

@xeno-by said:
Fixed by scala/scala@75696bc

@scabug scabug closed this as completed Feb 6, 2012
@scabug scabug added this to the 2.10.0-M1 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants