Scala Programming Language
  1. Scala Programming Language
  2. SI-5382

do not look for similar identifiers when typer should remain silent

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      typedIdent should not compute the `val similar` when the error message is never going to be presented to the user

      this is a killer in scala-virtualized, since we do a ton of typedIdent("infix_"+someName), only to find out whether that identifier exists – I had to kill ant quick.bin after 20 minutes (whereas it normally takes about 1:15min)

      I didn't see a robust way of detecting whether the reporter is silent or not, apart from `context.reportGeneralErrors`, but relying only on that condition broke your test cases, so I'm giving up and throwing the hot potato in your direction in hopes of your reflexes' making you catch it

        Activity

        Hide
        Adriaan Moors added a comment -

        Hubert, when you merge the new-style error-reporting can you have a look at this?

        Show
        Adriaan Moors added a comment - Hubert, when you merge the new-style error-reporting can you have a look at this?
        Hide
        Paul Phillips added a comment -

        I can eat this potato, dealing better with "silent" is very necessary anyway.

        Show
        Paul Phillips added a comment - I can eat this potato, dealing better with "silent" is very necessary anyway.
        Hide
        Hubert Plociniczak added a comment -

        which test exactly was it failing at?
        I am atm merging again with trunk, so Paul you can expect a huge pull request soon (enjoy!). I was going to wait for benchmarking to work again but that is taking too long for me and my own testing showed that performance is ok.
        It should be possible then to just call 'context.hasErrors' and voila (and inspect what can kind of error occurred if you have such a desire).

        Show
        Hubert Plociniczak added a comment - which test exactly was it failing at? I am atm merging again with trunk, so Paul you can expect a huge pull request soon (enjoy!). I was going to wait for benchmarking to work again but that is taking too long for me and my own testing showed that performance is ok. It should be possible then to just call 'context.hasErrors' and voila (and inspect what can kind of error occurred if you have such a desire).
        Hide
        Adriaan Moors added a comment -

        fixed by Paul in 8deade7d868dbd79194621d815ee6eee46f9807d

        Show
        Adriaan Moors added a comment - fixed by Paul in 8deade7d868dbd79194621d815ee6eee46f9807d

          People

          • Assignee:
            Paul Phillips
            Reporter:
            Adriaan Moors
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development