Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros expand even if their arguments contain erroneous trees #5438

Closed
scabug opened this issue Feb 6, 2012 · 2 comments
Closed

Macros expand even if their arguments contain erroneous trees #5438

scabug opened this issue Feb 6, 2012 · 2 comments
Assignees
Labels
Milestone

Comments

@scabug
Copy link

scabug commented Feb 6, 2012

{code:title=Typers.scala}
// begin adapt
tree.tpe match {
...
case _ =>
...
else if (inExprModeButNot(mode, FUNmode) && tree.symbol != null && tree.symbol.isMacro && !tree.isDef) {
val expansion = expandMacro(tree)
if (expansion.isErroneous) expansion else typed(expansion, mode, pt)
} else if ((mode & (PATTERNmode | FUNmode)) == (PATTERNmode | FUNmode)) {
...
}
}
{code}

Even if tree.exists(_.isErroneous), macro expansion logic still gets triggered by adapt. Moreover, in this case context.hasErrors is false. Is this okay?

@scabug
Copy link
Author

scabug commented Feb 6, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5438?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0

@scabug
Copy link
Author

scabug commented Feb 18, 2012

@xeno-by said:
Fixed by scala/scala@2fe5702

@scabug scabug closed this as completed Feb 18, 2012
@scabug scabug added the macros label Apr 7, 2017
@scabug scabug added this to the 2.10.0 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants