Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MutableSettings.copy needs a small fix #5446

Closed
scabug opened this issue Feb 8, 2012 · 3 comments
Closed

MutableSettings.copy needs a small fix #5446

scabug opened this issue Feb 8, 2012 · 3 comments
Assignees
@paulp
Milestone
2.10.0

Comments

@scabug
Copy link

scabug commented Feb 8, 2012

Commit 1b14f49ff297a29c489dd184ee8f1f3c885a1b33 added the following to AbsSettings:

  • // an argument list which (should) be usable to recreate the Settings
  • def recreateArgs = userSetSettings.toList flatMap (_.unparse)

But MutableSettings.copy was overlooked and to this day contains the code:

val xs = userSetSettings flatMap (_.unparse)
s.processArguments(xs.toList, true)

Note the misplaced toList. Could someone please fix MutableSettings, perhaps like:

s.processArguments(recreateArgs, true)

Thanks!
@scabug
Copy link
Author

scabug commented Feb 8, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5446?orig=1
Reporter: Jeremy Heiner (jheiner)
Affected Versions: 2.9.2, 2.10.0

@scabug
Copy link
Author

scabug commented Feb 14, 2012

@cvogt said:
That was your commit. Please decide if the suggestion is useful.

@scabug
Copy link
Author

scabug commented Feb 14, 2012

@paulp said:
bd988df644

@scabug scabug closed this as completed Feb 14, 2012
@scabug scabug added this to the 2.10.0 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulp paulp

Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
2 participants
@paulp @scabug