Imported From: https://issues.scala-lang.org/browse/SI-5543?orig=1
Reporter: @som-snytt
Affected Versions: 2.10.0-M2, 2.10.0
Other Milestones: 2.10.0

@cvogt said:
please re-assign, if you are not the right person

@som-snytt said:
I took a look and submitted a pull request.

scala/scala#317

The problem seems to be that when default-getters for constructors are added to the companion module, the expression has the module in scope.

Adding constrTyperIf(flag) before entering typedDefDef seems to work.

Since there is no flag for default-getter for ctor, it does a name compare. It might be preferable to add a flag or abuse an existing flag instead.

This change includes renaming init$default$ to init$$default$ to avoid collisions with default-getters for an ordinary method on the module named init.

That change is not trivial, so guidance is needed. Alternatively, one could live with the possibility of name collision and just allow that there are interactions that impose limits, similar to #5366.

More example:

object A {
  val v = 7
  class B(val x: Int = v)
  object B {
    val v = 5
    //def init(y: Int = v) = y  // names collide
  }
  def main(args: Array[String]) {
    println(new B().x) // 5
  }
}

@som-snytt said:
77b577a5aeab782b64b39b3a812c35fdd8ab265a
in
scala/scala#317

@lrytz said:
The fix goes too far because it also affects this references of auxiliary constructors.

object T {
  override def toString = "T"

  // here, `this` should refer to T. That's what was fixed
  class C(val x: Any = this) {
    override def toString() = "C"
  }

  class D(val x: Any) {
    override def toString() = "D"
    // here, `this` should refer to the D instance, but after the fix it also
    // refers to T.
    def this(a: Int, b: Int, c: Any = this) { this(c) }
  }
}

println((new T.C()).x)     // prints "T", correct
println((new T.D(0,0)).x)  // prints "T", should print "D"

@lrytz said:
actually i changed my mind, the fix / current behavior is correct. it doesn't make sense to have the class members in scope when typing (auxiliary or primary) constructor defaults (or types).

class C { type T; def this(x: T) { this() } }                 // gives `not found: type T`
class C(x: Int) { def this(a: Int, b: Int = x) { this(b) } }  // gives `not found: value x`
class C { val x = 0; def this(a: Int = x) { this() } }        // also  `not found: value x`

spec 5.3.1: The signature and the self constructor invocation of a constructor definition are type-checked and evaluated in the scope which is in effect at the point of the enclosing class definition, augmented by any type parameters of the enclosing class and by any early definitions of the enclosing template. The rest of the constructor expression is type-checked and evaluated as a function body in the current class.

@retronym said:
If you haven't already, could you please add a test that demonstrates that behaviour?

@lrytz said:
sure, will be part of the upcoming namer pull request

@adriaanm said:
Featured in Scala puzzlers just now :-) Should we really allow referring to this in defaults? This should not compile, but does:

object Foo {
case class Foo(x: String = this.toString)
}

Let's reboot the discussion.

@adriaanm said:
I want to focus on the next puzzler, so didn't look to closely at the rest of the ticket.

@som-snytt said:
Since this was my first ever contribution, and since I have to pick up my daughter to see the Met rebroadcast of La donna del lago so my day isn't a total bust, I'll go with my initial assessment. Not that I knew anything back then,

@som-snytt said:
P.S. Damn you, Scala Puzzlers! Damn you to perdition's flame!

@som-snytt said:
The comment on the puzzler was that this is another issue.

In the U.S., you get three years to amend a tax return and three years to amend a community contribution.

But if you're lucky, it won't get fixed before the second edition of the puzzlers book.

However, that should have read:

You're lucky if Jason doesn't notice the issue, assign it to himself and fix it before Scala Days. 
Or rather, at Scala Days during lunch the day of your presentation. Or maybe during the five
minutes you give people to figure out what's going on.

@som-snytt said:
Reclosing because the Puzzlers at ScalaDays should not result in an orgy of second-guessing. "Feel free to open a new ticket." What is the prize for being lucky 10000? Are we confident that Jira doesn't overflow?