Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor LabelDefs to MethodDefs #5562

Open
scabug opened this issue Mar 10, 2012 · 4 comments
Open

refactor LabelDefs to MethodDefs #5562

scabug opened this issue Mar 10, 2012 · 4 comments
Labels
typer
Milestone
Backlog

Comments

@scabug
Copy link

scabug commented Mar 10, 2012

Adriaan Moors
Mar 9, 6:08 pm

I just came across this in Duplicators. LabelDefs are not typable from trees alone, unless they have the type ()Unit. Therefore, their symbols are recreated ad-hoc and their types are fixed inline, instead of letting the namer/typer handle them, or Idents that refer to them.

http://groups.google.com/group/scala-internals/msg/087700e4c9f570ae
@scabug
Copy link
Author

scabug commented Mar 10, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5562?orig=1
Reporter: @xeno-by
Blocks #5464, #5694

@scabug
Copy link
Author

scabug commented Apr 25, 2012

@xeno-by said:
Assigning to you, Adriaan, since you're the one who's committed to refactor LabelDefs by 2.10 RC.

@scabug
Copy link
Author

scabug commented Jun 25, 2012

@adriaanm said:
type checking labels is not idempotent due to the way symbols are used for their arguments/paramters

we should get rid of them and model labels as methods whose symbol are flagged LABEL

@scabug scabug added the typer label Apr 7, 2017
@scabug scabug added this to the Backlog milestone Apr 7, 2017
@scala scala deleted a comment from scabug Mar 3, 2018
@scala scala deleted a comment from scabug Mar 3, 2018
@SethTisue
Copy link
Member

@adriaanm should this stay open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typer
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@SethTisue @scabug