improvments for synthetic case class hashCode #5781
Labels
Milestone
Comments
|
Imported From: https://issues.scala-lang.org/browse/SI-5781?orig=1 |
|
@paulp said:
case class Foo(x: Int, y: Int, z: String)
would give us
object Foo {
def classHashCode(x: Foo): Int = { // custom hashcode calculation }
def classEquals(x1: Foo, x2: Foo): Boolean = { // custom equals }
// apply, unapply, etc.
}
class Foo(val x: Int, y: Int, z: String) {
// now you can do, for instance, this:
override lazy val hashCode = Foo.classHashCode(this)
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In 0e197e89ac there are custom hashCodes being spun for case classes. Some things left to do:
tragically, specialized classes do not yet benefit. Not sure how to deal with that; I suppose it will have to go into the specialization phase.
if a class has nothing but generic elements in the product, there's no benefit to unrolling a giant series of "anyHash" calls. May as well just pass the product like before and save the code size.
Case classes should probably be seeded on the string representation of the class name, like case objects use for their hashcode. Right now everything is seeded wit the MurmurHash3 "product" seed.
The text was updated successfully, but these errors were encountered: