Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICode instruction invariants are missing #5819

Closed
scabug opened this issue May 22, 2012 · 5 comments
Closed

ICode instruction invariants are missing #5819

scabug opened this issue May 22, 2012 · 5 comments
Labels
backend enhancement

Comments

@scabug
Copy link

scabug commented May 22, 2012

Context for this: #5672 and discussion at scala/scala#596

assert(consumed == consumedTypes.size, 
       "Someone forgot to override consumedTypes() in " +  this)

Also merge in Paul's ICode cleanup: scala/scala@6e943125b3
@scabug
Copy link
Author

scabug commented May 22, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5819?orig=1
Reporter: @magarciaEPFL

@scabug
Copy link
Author

scabug commented May 23, 2012

@magarciaEPFL said:
Additionally,

// TODO Logical's 2nd elem should be declared ValueTypeKind, to better approximate its allowed values (isIntSized, its comments appears to convey)
// TODO GenICode uses `toTypeKind` to define that elem, `toValueTypeKind` would be needed instead.
// TODO How about adding some asserts to Logical and similar ones to capture the remaining constraint (UNIT not allowed).

@scabug
Copy link
Author

scabug commented May 23, 2012

@magarciaEPFL said:
In CZJUMP(success, failure, cond, kind), whenever kind.isRefOrArrayType , cond can't be one of GT, GE, LT, LE.

@scabug
Copy link
Author

scabug commented Aug 16, 2012

@VladUreche said:
Also related: #6234

@scabug scabug mentioned this issue Apr 7, 2017
Closed
@SethTisue
Copy link
Member

strong hunch this is no longer applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SethTisue @scabug