Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type-flow analysis reusing deltas to save ICode scans #5852

Closed
scabug opened this issue May 28, 2012 · 2 comments
Closed

type-flow analysis reusing deltas to save ICode scans #5852

scabug opened this issue May 28, 2012 · 2 comments

Comments

@scabug
Copy link

scabug commented May 28, 2012

For 2.11, extend the single-pass TFA at
magarciaEPFL/scala@master...SinglePassTFA
with the solution-repair optimizations added in 2.10-M2.

@scabug
Copy link
Author

scabug commented May 28, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5852?orig=1
Reporter: @magarciaEPFL
Assignee: @magarciaEPFL
Blocks #5850

@scabug
Copy link
Author

scabug commented Jun 20, 2012

@magarciaEPFL said:
A prototype to evaluate delta-based typeflow-analysis can be found at

https://github.com/magarciaEPFL/scala/compare/master...inliner211 

It also performs two micro-optimizations for speed:

  • Inlining ascribes type-flow-computed type to added locals, giving them in general more specific types than those declared in the callee's formal params.
  • Some methods calls are resolved as by-product of inlining analysis.
    However those calls to a more specific method (say, j.l.String.equals() instead of its Objectcounterpart) can't be devirtualized (ie madeinvokespecialinstead ofinvokevirtual`) because the JVM verifier complains (looks like our type-flow analysis, which tracks non-nullness, is more precise).

All in all, the single-pass approach isn't much faster than the current implementation. Therefore looks like we'll stick to the current implementation. Closing this ticket as Won't fix.

The technique to track non-nullness should be added to the current implementation, #5850 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant