New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consumedTypes/producedTypes in TypeFlowAnalysis and ICodeCheckers #6234
Comments
Imported From: https://issues.scala-lang.org/browse/SI-6234?orig=1 |
@magarciaEPFL said:
I don't see why |
@VladUreche said: stack popAndCheck cm.consumedTypes
cm.producedTypes foreach (stack push _) And the same for all instructions. WDTY? |
@magarciaEPFL said: Instead, further assertions can be added. In the example, before popping from the stack, an assert can be added to cross-check with |
@VladUreche said: |
@adriaanm said: |
likely no longer applicable |
The consumedTypes/producedTypes for icode instructions are redundantly defined in 3 separate places:
program point)
Since the Opcodes types are the only ones visible outside, I suggest
we use them in ICodeCheckers.scala and TypeFlowAnalysis.scala too. But
we should make such changes after the release, after chilling out
by the lake with a glass of good wine for a couple of days.
A relevant discussion on this can be found at:
https://groups.google.com/forum/?fromgroups#!topic/scala-internals/qcyTjk8euUI[1-25]
The text was updated successfully, but these errors were encountered: