Scala Programming Language
  1. Scala Programming Language
  2. SI-6240

thread safety of reflection API

          Details

            Description

            It's sort of implemented, but was never tested. Also trees aren't synchronized at all, because it was only recently when they've been converted to abstract types.

            NOTE that this issue mostly affects runtime reflection, not reflection used in macros. Compiler itself has never been thread-safe, so noone uses it from multiple threads, therefore issues might only arise if a macro spawns multiple threads, which do certain operations simultaneously.

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. SI-8131 residual race condition in runtime reflection

              • Blocker - Blocks development and/or testing work, production could not run.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                43 older comments
                Hide
                Permalink
                Stefan Gheorghiu added a comment -

                Great. Looking forward to confirming it fixed in 2.10.4. Hopefully, this will have a positive effects on thread-safety issues with precompilation of Scalate templates.

                Show
                Stefan Gheorghiu added a comment - Great. Looking forward to confirming it fixed in 2.10.4. Hopefully, this will have a positive effects on thread-safety issues with precompilation of Scalate templates.
                Hide
                Permalink
                Eugene Burmako added a comment -

                Please note that the linked pull request is submitted against master. A 2.10.4 fix will need an additional backport.

                Show
                Eugene Burmako added a comment - Please note that the linked pull request is submitted against master. A 2.10.4 fix will need an additional backport.
                Hide
                Permalink
                Jason Zaugg added a comment - - edited

                Closing as functionally fixed in 2.11.0-M7. Let's use new tickets for performance optimization (avoiding the big lock) or for backports.

                Show
                Jason Zaugg added a comment - - edited Closing as functionally fixed in 2.11.0-M7. Let's use new tickets for performance optimization (avoiding the big lock) or for backports.
                Hide
                Permalink
                Ngoc Dao added a comment -

                Scala 2.10.4-RC1 has been released.
                Will 2.10.4-Final contain the fix for this issue?

                Show
                Ngoc Dao added a comment - Scala 2.10.4-RC1 has been released. Will 2.10.4-Final contain the fix for this issue?
                Hide
                Permalink
                Jason Zaugg added a comment -

                No, it will not. In fact we are still struggling to fix this completely for 2.11.0, see SI-8131

                Show
                Jason Zaugg added a comment - No, it will not. In fact we are still struggling to fix this completely for 2.11.0, see SI-8131

                  People

                  • Assignee:
                    Eugene Burmako
                    Reporter:
                    Eugene Burmako
                  • Votes:
                    28 Vote for this issue
                    Watchers:
                    49 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development