Scala Programming Language
  1. Scala Programming Language
  2. SI-6289

Partest separate compilation with Java files in the `neg` category does not record Javac errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Scala 2.10.0-M6
    • Fix Version/s: Scala 2.11.0-M3
    • Component/s: Partest
    • Labels:
    • Environment:

      Mac OS X
      JDK 1.6

      Description

      1) Create a directory myBug in neg in Partest with:

      file_1.scala:

      class Const { val x = 1 }
      

      file_2.java:

      public class file_2 {
          public static void foo() {
              Const c = new Const();
              c.x = 2;
          }
      }
      

      Running:

      test/partest --show-log test/files/neg/
      

      gives:

      Testing individual files
      test/files/neg/myBug/file_2.java:4: error: x has private access in Const
              c.x = 2;
               ^
      1 error
      testing: [...]/files/neg/myBug                                        [  OK  ]
      All of 1 tests were successful (elapsed time: 00:00:02)
      

      although there is no check file with the produced output.

      2) Also, there are no compilation errors being printed out for run tests.

        Activity

        Hide
        Grzegorz Kossakowski added a comment -

        Changed priority to Major and rescheduled it to 2.10.2-RC1. Actually, I think tickets about infrastructure should not have Fix version set because they are less dependent on release schedule.

        Show
        Grzegorz Kossakowski added a comment - Changed priority to Major and rescheduled it to 2.10.2-RC1. Actually, I think tickets about infrastructure should not have Fix version set because they are less dependent on release schedule.
        Hide
        Paolo G. Giarrusso added a comment -

        Just to ensure everything is clear: part of the test suite is not being effective. ("Does the problem disappear when running the whole test suite?" "No, it does not disappear."). Hence technical debt might be growing right now - meaning the day this is fixed you might discover than N testcases broke. Imagine that happening the day before the release date.

        If yours was a conscious decision, Grzegorz, then I respect it, I'm just confused about it.

        Show
        Paolo G. Giarrusso added a comment - Just to ensure everything is clear: part of the test suite is not being effective. ("Does the problem disappear when running the whole test suite?" "No, it does not disappear."). Hence technical debt might be growing right now - meaning the day this is fixed you might discover than N testcases broke. Imagine that happening the day before the release date. If yours was a conscious decision, Grzegorz, then I respect it, I'm just confused about it.
        Hide
        Adriaan Moors added a comment -

        I agree with Paolo, new features is one thing, but silent failure in our test infrastructure is quite serious.

        Show
        Adriaan Moors added a comment - I agree with Paolo, new features is one thing, but silent failure in our test infrastructure is quite serious.
        Hide
        A. P. Marki added a comment - - edited

        This PR from paulp's partest-sprint is against master, further tweaks and testing required; I haven't diffed against 2.10.x.

        Revised:
        https://github.com/scala/scala/pull/2328

        Freebased:
        https://github.com/scala/scala/pull/2350
        with additional nudge to the build by paulp

        I just read that the computer keyboard is one of the top ten germiest spots in the house, after the kitchen sponge but before the kitchen sink.

        One reason is the people drooling over partest in color:

        https://groups.google.com/d/msg/scala-internals/X_O5MLpun5o/Ha_s9Eml_zQJ

        Show
        A. P. Marki added a comment - - edited This PR from paulp's partest-sprint is against master, further tweaks and testing required; I haven't diffed against 2.10.x. Revised: https://github.com/scala/scala/pull/2328 Freebased: https://github.com/scala/scala/pull/2350 with additional nudge to the build by paulp I just read that the computer keyboard is one of the top ten germiest spots in the house, after the kitchen sponge but before the kitchen sink. One reason is the people drooling over partest in color: https://groups.google.com/d/msg/scala-internals/X_O5MLpun5o/Ha_s9Eml_zQJ
        Hide
        A. P. Marki added a comment -

        Disinfect your keyboards.

        https://github.com/scala/scala/pull/2353

        Show
        A. P. Marki added a comment - Disinfect your keyboards. https://github.com/scala/scala/pull/2353

          People

          • Assignee:
            A. P. Marki
            Reporter:
            Aleksandar Prokopec
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development