Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short value classes guide for docs.scala-lang #6398

Closed
scabug opened this issue Sep 19, 2012 · 10 comments
Closed

Short value classes guide for docs.scala-lang #6398

scabug opened this issue Sep 19, 2012 · 10 comments

Comments

@scabug
Copy link

scabug commented Sep 19, 2012

(No description for SI-6398.)

@scabug
Copy link
Author

scabug commented Sep 19, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6398?orig=1
Reporter: @heathermiller
Blocks #6397
Attachments:

@scabug
Copy link
Author

scabug commented Sep 19, 2012

@harrah said:
A first draft that assumes #6408 is fixed by disallowing nested templates in universal traits. Please review for correctness especially the section on when allocations occur.

@scabug
Copy link
Author

scabug commented Sep 20, 2012

@jsuereth said:
Hey, I'm posting another version of your guide. It looks excellent and detailed. Just what we want. I'm cleaning up some wording/transitions a bit and adding a few details I think are helpful as well.

@scabug
Copy link
Author

scabug commented Sep 20, 2012

@retronym said:
A few minor suggestions:

s/RichInt$.MODULE$.extension$toHexString(3)/RichInt.extension$toHexString(3)/

(I don't think discussion of MODULE$ is necessary in this context)

s/rather than a method call on a newly instantiated object/rather than new RichInt(3).toHexString.

(Just to be explicit)

@scabug
Copy link
Author

scabug commented Sep 20, 2012

@jsuereth said:
Good suggestions, posting new file shortly.

@scabug
Copy link
Author

scabug commented Sep 20, 2012

@jsuereth said:
TAKE 2 (w/ jason's comments.

@scabug
Copy link
Author

scabug commented Oct 29, 2012

@jsuereth said:
Taking over this ticket.

Mark - I'll submit this as a pull request against scala.github.com for you so that this makes it before the next RC2.

@scabug
Copy link
Author

scabug commented Oct 29, 2012

@heathermiller said:
No worries Josh- this one isn't forgotten.

@scabug
Copy link
Author

scabug commented Nov 2, 2012

@heathermiller said:
Added in: scala/docs.scala-lang@f2bc991

@scabug
Copy link
Author

scabug commented Nov 2, 2012

@heathermiller said:
Thanks a lot Mark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants