Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structural dispatch with invoke-dynamic uses old APIs #6545

Closed
scabug opened this issue Oct 19, 2012 · 3 comments
Closed

Structural dispatch with invoke-dynamic uses old APIs #6545

scabug opened this issue Oct 19, 2012 · 3 comments
Assignees
@paulp
Labels
duplicate structural types

Comments

@scabug
Copy link

scabug commented Oct 19, 2012

After upgrading to Java 7, I was curious to see if it would have any performance impact on the places where I use structural dispatch in my project. I guess ClassNotFoundException pops up pretty quickly, but it wasn't exactly what I was hoping for.... :-)

It seems that the -Ystruct-dispatch:invoke-dynamic option is still based on an early version of the JSR, when the code still lived in java.dyn. It has since been refactored a bit and transitioned into java.lang.invoke.

Easily worked around by going back to cached dispatch.
@scabug
Copy link
Author

scabug commented Oct 19, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6545?orig=1
Reporter: Sarah Gerweck (gerweck)
Affected Versions: 2.9.2
Duplicates #7492

@scabug
Copy link
Author

scabug commented Oct 24, 2012

@adriaanm said:
this is definitely on the table, but we're not actively working on this right now

@scabug
Copy link
Author

scabug commented Oct 26, 2012

Sarah Gerweck (gerweck) said:
I'm not suggesting that this work should be urgent, but it might make sense to disable the option if it's easy. I know -Y options generally fall in the "at your own risk" category but I'd hate for somebody to turn this on and have the issue slip past their testing.

@scabug scabug closed this as completed May 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulp paulp

Labels
duplicate structural types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulp @scabug