Scala Programming Language
  1. Scala Programming Language
  2. SI-6562

Scala compiler crashes during lamdalift due to assertion failure

    Details

      Description

      The following code causes the compiler to crash. When the @inline annotation is removed, the compiler seems to work ok.

      Test.scala
      class Test {
      
        @inline
        private def foo {
            def it {
            }
          List().foreach { _ => it }
        }
      }
      

        Issue Links

          Activity

          Hide
          Jason Zaugg added a comment -

          Here's the now-breaking test:

          https://github.com/retronym/scala/commit/d6d6ad6

          My concern about qualified private members was misplaced: these are already !isPrivate, and as such not subject to the whims of makeNotPrivate.

          Show
          Jason Zaugg added a comment - Here's the now-breaking test: https://github.com/retronym/scala/commit/d6d6ad6 My concern about qualified private members was misplaced: these are already !isPrivate, and as such not subject to the whims of makeNotPrivate .
          Hide
          Jason Zaugg added a comment -

          Inliners will either have to replicate the makeNotPrivate calls (fragile?) or figure out that names are expanded based on the Java signature (major surgery?).

          A tentative fix drawn from the fragile basket:

          https://github.com/retronym/scala/commit/b4aedd23

          Show
          Jason Zaugg added a comment - Inliners will either have to replicate the makeNotPrivate calls (fragile?) or figure out that names are expanded based on the Java signature (major surgery?). A tentative fix drawn from the fragile basket: https://github.com/retronym/scala/commit/b4aedd23
          Show
          Jason Zaugg added a comment - https://github.com/scala/scala/pull/1556
          Hide
          Adriaan Moors added a comment -

          Workaround in https://github.com/scala/scala/pull/1561. Lowering priority, shifting gaze.

          Show
          Adriaan Moors added a comment - Workaround in https://github.com/scala/scala/pull/1561 . Lowering priority, shifting gaze.
          Hide
          Jason Zaugg added a comment -

          Moved the (serious, IMO) residual issues to SI-6608

          Show
          Jason Zaugg added a comment - Moved the (serious, IMO) residual issues to SI-6608

            People

            • Assignee:
              Jason Zaugg
              Reporter:
              Robby
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development