Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value class with method signature dependent on constructor parameter = crash #6651

Closed
scabug opened this issue Nov 11, 2012 · 5 comments
Closed

Value class with method signature dependent on constructor parameter = crash #6651

scabug opened this issue Nov 11, 2012 · 5 comments
Assignees
@retronym
Labels
has PR valueclass
Milestone
2.10.1

Comments

@scabug
Copy link

scabug commented Nov 11, 2012 

trait Path {
  type Dep
}

final class ValueClass[P <: Path](val path: P) extends AnyVal {
  import path._
  def apply(dep: Dep): Dep = dep
}

Gives:

uncaught exception during compilation: scala.reflect.internal.Types$TypeError
scala.reflect.internal.Types$TypeError: type mismatch;
 found   : ValueClass[P]#path.Dep
 required: ValueClass.this.path.Dep
	at scala.tools.nsc.typechecker.Contexts$Context.issueCommon(Contexts.scala:375)
	at scala.tools.nsc.typechecker.Contexts$Context.issue(Contexts.scala:379)
	at scala.tools.nsc.typechecker.ContextErrors$ErrorUtils$.issueTypeError(ContextErrors.scala:84)
	at scala.tools.nsc.typechecker.ContextErrors$ErrorUtils$.issueNormalTypeError(ContextErrors.scala:69)
	at scala.tools.nsc.typechecker.ContextErrors$TyperContextErrors$TyperErrorGen$.AdaptTypeError(ContextErrors.scala:176)
	at scala.tools.nsc.typechecker.Typers$Typer.fallBack$1(Typers.scala:1249)
	at scala.tools.nsc.typechecker.Typers$Typer.adapt(Typers.scala:1254)
	at scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5467)
	at scala.tools.nsc.interpreter.ReplGlobal$$anon$1$$anon$2.typed(ReplGlobal.scala:29)
	at scala.tools.nsc.typechecker.Typers$Typer.transformedOrTyped(Typers.scala:5658)
	at scala.tools.nsc.typechecker.Typers$Typer.typedDefDef(Typers.scala:2169)
	at scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:5386)
	at scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5458)
	at scala.tools.nsc.interpreter.ReplGlobal$$anon$1$$anon$2.typed(ReplGlobal.scala:29)
	at scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5509)
	at scala.tools.nsc.typechecker.Typers$Typer.typedPos(Typers.scala:5514)
	at scala.tools.nsc.transform.ExtensionMethods$Extender$$anonfun$transformStats$1$$anonfun$11$$anonfun$apply$7.apply(ExtensionMethods.scala:191)
	at scala.tools.nsc.transform.ExtensionMethods$Extender$$anonfun$transformStats$1$$anonfun$11$$anonfun$apply$7.apply(ExtensionMethods.scala:191)
	at scala.reflect.api.Trees$Transformer.atOwner(Trees.scala:2872)
	at scala.tools.nsc.transform.TypingTransformers$TypingTransformer.atOwner(TypingTransformers.scala:34)
	at scala.tools.nsc.transform.TypingTransformers$TypingTransformer.atOwner(TypingTransformers.scala:28)
	at scala.tools.nsc.transform.ExtensionMethods$Extender$$anonfun$transformStats$1$$anonfun$11.apply(ExtensionMethods.scala:191)
	at scala.tools.nsc.transform.ExtensionMethods$Extender$$anonfun$transformStats$1$$anonfun$11.apply(ExtensionMethods.scala:190)

By contrast, this compiles:

final class ValueClass[P <: Path](val path: P) extends AnyVal {
  import path._
  def apply(dep: Dep): Dep = dep
}

Although even in the second case, the signature appears incorrect:

final def apply$extension[P >: Nothing <: Path]($this: ValueClass[P])(dep: ValueClass.this.path.Dep): Path#Dep = dep;

The formal type of the parameter dep should have a substitution applied from ValueClass.this.type -> $this.type.
@scabug
Copy link
Author

scabug commented Nov 11, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6651?orig=1
Reporter: @retronym
Affected Versions: 2.10.0-RC2

@scabug
Copy link
Author

scabug commented Nov 11, 2012

@xeno-by said:
Looks like the working example is missing a line or two.

@scabug
Copy link
Author

scabug commented Nov 11, 2012

@retronym said (edited on Nov 11, 2012 11:25:28 PM UTC):
This must be close to a fix, but it still crashes:

diff --git a/src/compiler/scala/tools/nsc/transform/ExtensionMethods.scala b/src/compiler/scala/tools/nsc/transform/ExtensionMethods.scala
index 6cc957a..e5d30eb 100644
--- a/src/compiler/scala/tools/nsc/transform/ExtensionMethods.scala
+++ b/src/compiler/scala/tools/nsc/transform/ExtensionMethods.scala
@@ -124,7 +124,8 @@ abstract class ExtensionMethods extends Transform with TypingTransformers {
           MethodType(List(thisParam), restpe)
       }
       val GenPolyType(tparams, restpe) = origInfo cloneInfo extensionMeth
-      GenPolyType(tparams ::: newTypeParams, transform(restpe) substSym (clazz.typeParams, newTypeParams))
+      val newResType = transform(restpe) substThisAndSym (clazz, singleType(currentOwner.companionModule.thisType, thisParam), clazz.typeParams, ne
+      GenPolyType(tparams ::: newTypeParams, newResType)
     }
 
     private def allParams(tpe: Type): List[Symbol] = tpe match {


  last tree to typer: Ident(dep)
              symbol: value dep (flags: <param> <triedcooking>)
   symbol definition: dep: $this.path.Dep
       symbol owners: value dep -> method apply$extension -> object ValueClass -> package <empty>
      context owners: method apply$extension -> object ValueClass -> package <empty>

// final def apply$extension[P <: Path]($this: ValueClass[P])(dep: $this.path.Dep): $this.path.Dep in object ValueClass

uncaught exception during compilation: scala.reflect.internal.Types$TypeError
error: scala.reflect.internal.Types$TypeError: type mismatch;
 found   : ValueClass[P]#path.Dep
 required: $this.path.Dep

One for another day...

@scabug
Copy link
Author

scabug commented Dec 29, 2012

@retronym said:
Another example:

class YouAreYourself[A <: AnyRef](val you: A) extends AnyVal {
  def yourself: you.type = you
}

@scabug
Copy link
Author

scabug commented Jan 16, 2013

@retronym said:
scala/scala#1912

@scabug scabug closed this as completed Jan 30, 2013
@scabug scabug added this to the 2.10.1 milestone Apr 7, 2017
@scabug scabug mentioned this issue Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retronym retronym

Labels
has PR valueclass
Projects
None yet
Milestone
2.10.1
Development

No branches or pull requests
2 participants
@retronym @scabug