Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro engine shouldn't catch fatal exceptions #6748

Closed
scabug opened this issue Dec 2, 2012 · 3 comments
Closed

Macro engine shouldn't catch fatal exceptions #6748

scabug opened this issue Dec 2, 2012 · 3 comments
Labels
macros

Comments

@scabug
Copy link

scabug commented Dec 2, 2012

Problematic code: https://github.com/scala/scala/blob/6858d9a2fffd7e85144e16a5e636c2b1c95c2b3a/src/compiler/scala/tools/nsc/typechecker/Macros.scala#L783

Explanation of why it's problematic: scala/scala#1686 (comment)
@scabug
Copy link
Author

scabug commented Dec 2, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6748?orig=1
Reporter: @xeno-by

@scabug
Copy link
Author

scabug commented Dec 4, 2012

@xeno-by said:
But on the other hand we shouldn't let fatals induced by macros crash the compiler: #6682.

@scabug scabug added this to the Backlog milestone Apr 7, 2017
@SethTisue
Copy link
Member

fixed by scala/scala#6344, I think?

@SethTisue SethTisue removed this from the Backlog milestone Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macros
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SethTisue @xeno-by @scabug