Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c.freshName is broken #6879

Closed
scabug opened this issue Dec 25, 2012 · 4 comments
Closed

c.freshName is broken #6879

scabug opened this issue Dec 25, 2012 · 4 comments
Labels
Milestone

Comments

@scabug
Copy link

scabug commented Dec 25, 2012

http://groups.google.com/group/scala-internals/browse_thread/thread/684f353157488429

@scabug
Copy link
Author

scabug commented Dec 25, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6879?orig=1
Reporter: @xeno-by
Affected Versions: 2.10.0
Blocks #7823

@scabug
Copy link
Author

scabug commented Jan 22, 2014

@xeno-by said (edited on Jan 22, 2014 3:54:34 PM UTC):
scala/scala#3401

Instead of per-compilation unit unique counters, the freshName API now
uses a per-Global counter. Fresh names now also contain dollars to exclude
clashes with supported user-defined names (the ones without dollar signs).

This doesn’t fix the bug, because per-Global counters get created anew
every time a new Global is instantiated, and that provides some potential
for name clashes even for def macros, but at least it completely excludes
clashes in typical situations.

@SethTisue
Copy link
Member

Anyone have an opinion on whether this should stay open?

@SethTisue SethTisue added macros and removed has PR labels Jun 13, 2023
@joroKr21
Copy link
Member

As a macro library author, I don't remember seeing any clashes. I don't think avoiding clashes between multiple Global instances is something we can / should reasonably support.

@SethTisue SethTisue closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants