New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partest includes VM Warnings in compared output #7198
Comments
Imported From: https://issues.scala-lang.org/browse/SI-7198?orig=1 |
@huitseeker said (edited on Mar 6, 2013 6:10:36 PM UTC): That way it would remove lines that match that particular filter from the program's output before comparing it to the |
@som-snytt said: I have an experimental "modeline"-style feature for configs. It was motivated by scalacheck options, e.g.: /*
* scalac: -deprecation
* scalacheck: -workers 1 -minSize 0 -maxSize 4000 -minSuccessfulTests 5
*/ For config specific to a test, it avoids extra files; my other idea was to process "enclosing" .flags files, e.g., presentation.flags. Either in a .flags or header, Or The other thing I noticed it that we compare stdout + stderr. It would be nice to be able to diff only stdout. I see my code uses a ProcessLogger (I forget that Process API as soon as I use it). |
@som-snytt said: The commit uses a filters file for all tests, or all of a kind. The other use case would be to turn off the inliner warning for everything; right now, a handful of tests specify that filter in a source header. |
@som-snytt said: |
partest
compares raw output from Runner invocation, including warnings from the VM potentially unrelated to the test being run. This can result in false positives.For example, if my system-wide
_JAVA_OPTIONS
includes-XX:+UseLargePages
, it is to be expected that partest's parallel invocations will exhaust the reserved space for large pages on my system, triggering an ENOSPC. Here is one output ofpartest --show-diff --presentation
Problems:
--show-diff
+UseLargePages
is of limited use withpartest
, it has its use cases as a system-wide setting, as do many other edgy options.The text was updated successfully, but these errors were encountered: