Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scala.collection.immutable.HashSet should implement subsetOf #7326

Closed
scabug opened this issue Apr 3, 2013 · 2 comments
Closed

scala.collection.immutable.HashSet should implement subsetOf #7326

scabug opened this issue Apr 3, 2013 · 2 comments
Labels
enhancement library performance
Milestone
2.11.0-M8

Comments

@scabug
Copy link

scabug commented Apr 3, 2013

subsetOf can be implemented much more quickly for two HashSets than for two generic sets. So there should be a special case for HashSet.subsetOf when the argument is a HashSet as well.

subsetOf is one of the fundamental set operations, and it is also used by equality. So this should be as fast as possible.
@scabug
Copy link
Author

scabug commented Apr 3, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7326?orig=1
Reporter: @rklaehn
Assignee: @rklaehn
Affected Versions: 2.11.0-M2
See #6196, #6253

@scabug
Copy link
Author

scabug commented Jan 15, 2014

@Ichoran said:
scala/scala#3315

@scabug scabug closed this as completed Jan 15, 2014
@scabug scabug added this to the 2.11.0-M8 milestone Apr 7, 2017
@lrytz lrytz mentioned this issue Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement library performance
Projects
None yet
Milestone
2.11.0-M8
Development

No branches or pull requests
1 participant
@scabug