Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partest: compiler crashes, then reports test passed #7409

Closed
scabug opened this issue Apr 23, 2013 · 8 comments
Closed

partest: compiler crashes, then reports test passed #7409

scabug opened this issue Apr 23, 2013 · 8 comments
Assignees
@som-snytt
Labels
build
Milestone
2.11.0-M3

Comments

@scabug
Copy link

scabug commented Apr 23, 2013 

% test/partest --failed --update-check
Selected 9 tests drawn from previously failed tests

# starting 5 tests in neg
exception when typing $this.i().hashCode()/class scala.reflect.internal.Trees$Apply
class Funky is abstract; cannot be instantiated in file /scratch/trunk4/test/files/neg/t6283.scala
scala.reflect.internal.Types$TypeError: class Funky is abstract; cannot be instantiated
	at scala.tools.nsc.typechecker.Contexts$Context.issueCommon(Contexts.scala:420)
	at scala.tools.nsc.typechecker.Contexts$Context.issue(Contexts.scala:424)
	at scala.tools.nsc.typechecker.Infer$Inferencer.issue(Infer.scala:307)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$normalTypedApply$1$1.apply(Typers.scala:4494)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$normalTypedApply$1$1.apply(Typers.scala:4494)
	at scala.tools.nsc.typechecker.Typers$Typer.onError$3(Typers.scala:4465)
	at scala.tools.nsc.typechecker.Typers$Typer.normalTypedApply$1(Typers.scala:4494)
	at scala.tools.nsc.typechecker.Typers$Typer.typedApply$1(Typers.scala:4521)
	at scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:5205)
...
unhandled exception while transforming t6283.scala
ok   1 - neg/t6283.scala                         
...

9/9 passed (elapsed time: 00:00:16)
Test Run PASSED
@scabug
Copy link
Author

scabug commented Apr 23, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7409?orig=1
Reporter: @paulp

@scabug
Copy link
Author

scabug commented Apr 23, 2013

@paulp said:
It seems it will happily update the checkfile with the crash dump. The key is that in neg tests it needs to distinguish between crashes and other non-zero exit codes.

@scabug
Copy link
Author

scabug commented Apr 23, 2013

@som-snytt said:
I bet you don't mind if I look at it; I just looked at scalacheck fails not failing.

My PR will arrive in what will seem like dog years to you, or years to a dog traveling near the speed of light.

@scabug
Copy link
Author

scabug commented Apr 23, 2013

@retronym said:
A drive by feature request: add a third status, 'updated', to go with 'ok', and 'fail'.

@scabug
Copy link
Author

scabug commented Apr 24, 2013

@som-snytt said:
And skipped! And crashed! And burned!

My other branch adds, let's see, timeout! and canceled! I guess error means crashed?

"Drive-by" or is it "drive-through"? Like In'n'Out!

@scabug
Copy link
Author

scabug commented Apr 24, 2013

@som-snytt said:
One more: when you specify flags, you should be able to specify conditions under which a test must be skipped because it must fail, e.g., not enough memory for a huge BitSet. There's no reason to run a test that can't possibly succeed under the test conditions. I'm open to suggestions for a naming convention for "set up to fail" status.

And why is there updated but no downdated? Or is that when there is no second date?

@scabug
Copy link
Author

scabug commented Apr 24, 2013

@som-snytt said:
scala/scala#2446

includes "updated" status. Does not actually distinguish between crashing and burning.

@scabug
Copy link
Author

scabug commented May 1, 2013

@som-snytt said:
scala/scala#2476

@scabug scabug closed this as completed May 1, 2013
@scabug scabug added the build label Apr 7, 2017
@scabug scabug added this to the 2.11.0-M3 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@som-snytt som-snytt

Labels
build
Projects
None yet
Milestone
2.11.0-M3
Development

No branches or pull requests
2 participants
@som-snytt @scabug