You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before #5604 was fixed for good (in scala/scala@e6f10b0 ) defensive code was in charge of rescueing compilation upon that bug being hit. That defensive code has been made "unreachable" by the fix in question, as pointed out by @gkossakowski.
In order to test the waters without that defensive code, commit magarciaEPFL/scala@2cba077 turns that defensive code into an abort() with descriptive message (although there's already a test, it never hurts to have an additional assert in the compiler thus preventing regressions).
Running the nightly (for each of GenASM, GenBCode) doesn't trigger the abort() in question.
This ticket reminds us to rephrase that defensive code (as in magarciaEPFL/scala@2cba077) once GenBCode has been merged (actually could be rephrased already for GenASM).
The text was updated successfully, but these errors were encountered:
Before #5604 was fixed for good (in scala/scala@e6f10b0 ) defensive code was in charge of rescueing compilation upon that bug being hit. That defensive code has been made "unreachable" by the fix in question, as pointed out by @gkossakowski.
In order to test the waters without that defensive code, commit magarciaEPFL/scala@2cba077 turns that defensive code into an
abort()
with descriptive message (although there's already a test, it never hurts to have an additional assert in the compiler thus preventing regressions).Running the nightly (for each of GenASM, GenBCode) doesn't trigger the
abort()
in question.This ticket reminds us to rephrase that defensive code (as in magarciaEPFL/scala@2cba077) once GenBCode has been merged (actually could be rephrased already for GenASM).
The text was updated successfully, but these errors were encountered: