Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defensive code in bytecode emitter made redundant by existing fix to SI-5604 #7621

Closed
scabug opened this issue Jun 27, 2013 · 5 comments
Closed
Assignees

Comments

@scabug
Copy link

scabug commented Jun 27, 2013

Before #5604 was fixed for good (in scala/scala@e6f10b0 ) defensive code was in charge of rescueing compilation upon that bug being hit. That defensive code has been made "unreachable" by the fix in question, as pointed out by @gkossakowski.

In order to test the waters without that defensive code, commit magarciaEPFL/scala@2cba077 turns that defensive code into an abort() with descriptive message (although there's already a test, it never hurts to have an additional assert in the compiler thus preventing regressions).

Running the nightly (for each of GenASM, GenBCode) doesn't trigger the abort() in question.

This ticket reminds us to rephrase that defensive code (as in magarciaEPFL/scala@2cba077) once GenBCode has been merged (actually could be rephrased already for GenASM).

@scabug
Copy link
Author

scabug commented Jun 27, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7621?orig=1
Reporter: @magarciaEPFL
See #5604

@scabug
Copy link
Author

scabug commented Sep 4, 2013

@magarciaEPFL said:
scala/scala#2889

@scabug
Copy link
Author

scabug commented Sep 5, 2013

@magarciaEPFL said:
Superceded by scala/scala#2908

@scabug
Copy link
Author

scabug commented Feb 21, 2014

@magarciaEPFL said:
To merge once 2.12.x becomes available:

magarciaEPFL/scala@90a5eb7

@scabug
Copy link
Author

scabug commented Jan 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants