Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Future.completed method #7948

Closed
scabug opened this issue Nov 4, 2013 · 3 comments
Closed

Add Future.completed method #7948

scabug opened this issue Nov 4, 2013 · 3 comments
Assignees
@retronym
Labels
enhancement library
Milestone
2.11.0-M6

Comments

@scabug
Copy link

scabug commented Nov 4, 2013

Flesh out the Future factory methods to include a method that accepts a Try. At the moment we have Promise.success/Future.successful, Promise.fail/Future.failure, but we're missing the equivalent to Promise.complete.

Suggested: Future.completed.

e.g.

def completed[A](result: Try[A]): Future[A] = …
@scabug
Copy link
Author

scabug commented Nov 4, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7948?orig=1
Reporter: @richdougherty
Affected Versions: 2.11.0-M6

@scabug
Copy link
Author

scabug commented Nov 4, 2013

@retronym said:
Does this fit the bill?

scala/scala@9fe6b69268efc69

@scabug scabug closed this as completed Nov 4, 2013
@scabug
Copy link
Author

scabug commented Nov 4, 2013

@richdougherty said:
Perfect!

@scabug scabug added this to the 2.11.0-M6 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retronym retronym

Labels
enhancement library
Projects
None yet
Milestone
2.11.0-M6
Development

No branches or pull requests
2 participants
@retronym @scabug