Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompilerControl.askTypeAt(pos) should return the chain of parents containing pos, and not only the innermost tree #8136

Open
scabug opened this issue Jan 10, 2014 · 4 comments
Open

CompilerControl.askTypeAt(pos) should return the chain of parents containing pos, and not only the innermost tree #8136

scabug opened this issue Jan 10, 2014 · 4 comments
Labels
enhancement presentation compiler
Milestone
Backlog

Comments

@scabug
Copy link

scabug commented Jan 10, 2014

Based on a this discussion related to both #5064 #8125, it was suggested by Iulian that CompilerControl.askTypeAt(pos) would be changed so that it returns the whole chain of parents (with an opaque range position) that include the passed pos.

Benefits:

  1. No need to create opaque range position for Trees that should really have a transparent positions. This discussion should prove the point.

  2. The solution is general enough, and will reduce code duplication, as there are several places in the IDE codebase where we need to access the parent of a Tree.
@scabug
Copy link
Author

scabug commented Jan 10, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8136?orig=1
Reporter: @dotta
Affected Versions: 2.11.0-M7

@scabug
Copy link
Author

scabug commented Jan 13, 2014

@dotta said:
scala/scala#3358

@scabug
Copy link
Author

scabug commented Aug 5, 2014

@gkossakowski said:
The 2.11.2 is out so I'm rescheduling the issue for 2.11.3.

@scabug
Copy link
Author

scabug commented Nov 4, 2014

@retronym said:
Updating fix-by version to 2.11.5.

@scabug scabug added this to the Backlog milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement presentation compiler
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dotta @scabug