Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change in scalap breaks JSON libraries #8345

Closed
scabug opened this issue Feb 26, 2014 · 8 comments
Closed

Change in scalap breaks JSON libraries #8345

scabug opened this issue Feb 26, 2014 · 8 comments
Assignees
@gkossakowski
Milestone
2.11.0-RC1

Comments

@scabug
Copy link

scabug commented Feb 26, 2014

The f2de2c4ec43 changed package name in scalap from scalap.scala.tools.scalap.scalax.rules to scalap.scala.tools.scalap.rules. Arguably, the old package name was unfortunate but that change breaks both lift-json and json4s. It makes cross-compiling of those libraries against 2.10 and 2.11 close to impossible.

We've got two choices:

  1. Revert the change to package names
  2. Introduce package objects in the old package with deprecated type aliases and vals for objects.

Given the timing (it's really late) I'll probably go for the first option.
@scabug
Copy link
Author

scabug commented Feb 26, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8345?orig=1
Reporter: @gkossakowski
Affected Versions: 2.11.0-M8

@scabug
Copy link
Author

scabug commented Feb 26, 2014

@soc said:
Better question would be why they are using scalap in the first place. Also, it's clearly in the scala.tools namespace, so no compatibility guarantees apply.

@scabug
Copy link
Author

scabug commented Feb 26, 2014

@gkossakowski said:
Probably because they didn't have any better API available at the time. Therefore, I think we take the responsibility for not breaking them, unfortunately. In 2.12 we can revisit whether we can help them to migrate to something more officially supported.

@scabug
Copy link
Author

scabug commented Feb 26, 2014

@adriaanm said (edited on Feb 26, 2014 5:42:30 PM UTC):
We're building as much of the eco-system automatically to test RC1 for regressions. This came up as a regression that keeps us from compiling Lift and thus from testing whether we break it any other way, so the expedient thing to do, sadly, is to revert the patch.

@scabug
Copy link
Author

scabug commented Feb 27, 2014

@adriaanm said:
scala/scala#3588

@scabug scabug closed this as completed Feb 27, 2014
@scabug
Copy link
Author

scabug commented Apr 7, 2014

@soc said:
Looks like they are not that much interested in building Lift on Scala 2.11 anyway: lift/framework#1527
Too late for now, but probably good to keep that in mind for the future.

@scabug
Copy link
Author

scabug commented Apr 7, 2014

@adriaanm said:
Yeah, it's really too bad all that effort goes unappreciated (to put it mildly).

@scabug
Copy link
Author

scabug commented Apr 8, 2014

@som-snytt said:
That commit could never work. Even modulo tests compiling. The prefix of the SHA is "dead".

nafg/framework@dead6f0

Spooky.

@scabug scabug added the critical label Apr 7, 2017
@scabug scabug added this to the 2.11.0-RC1 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkossakowski gkossakowski

Labels
None yet
Projects
None yet
Milestone
2.11.0-RC1
Development

No branches or pull requests
2 participants
@gkossakowski @scabug