New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c.i.Set#toSet is unsound, warns against overriding with sound version #8346
Comments
Imported From: https://issues.scala-lang.org/browse/SI-8346?orig=1 |
@Ichoran said: |
Stephen Compall (s11001001) said: |
@Ichoran said: |
Stephen Compall (s11001001) said: |
@Ichoran said: |
@adriaanm said: |
@adriaanm said: |
Stephen Compall (s11001001) said: |
@Ichoran said: |
3cc99d7 deprecated overriding the casting
Set#toSet
introduced in #3953. This cast is demonstrably unsafe, so at least overriding should not be deprecated, unless the types of operations like+
change. I imagine the cast should be overridden in the collections library where it is unsound, or moved to leaves where it's known to be sound.The above CCE occurs in 2.10.3, 2.10.4-RC3, and 2.11.0-M8. The deprecation warning occurs in 2.11.0-M8.
The text was updated successfully, but these errors were encountered: