Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes in whitebox typecheck order break unit insertion #8352

Closed
scabug opened this issue Feb 27, 2014 · 2 comments
Closed

changes in whitebox typecheck order break unit insertion #8352

scabug opened this issue Feb 27, 2014 · 2 comments
Assignees
Milestone

Comments

@scabug
Copy link

scabug commented Feb 27, 2014

import scala.reflect.macros.whitebox._
import scala.language.experimental.macros

object Macros {
  def impl(c: Context)(x: c.Expr[Boolean]): c.Expr[Boolean] = x
  def foo(x: Boolean): Boolean = macro impl
}

object Test extends App {
  def expectUnit() {
    Macros.foo(true)
  }
}

19:47 ~/Projects/Scala2110M8/sandbox (HEAD)$ ss
Test.scala:3: warning: a pure expression does nothing in statement position; you may be omitting necessary parentheses
    Macros.foo(true)
               ^
Test.scala:3: error: type mismatch;
 found   : Unit
 required: Boolean
    Macros.foo(true)
               ^
one warning found
one error found
@scabug
Copy link
Author

scabug commented Feb 27, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8352?orig=1
Reporter: @xeno-by
Affected Versions: 2.11.0-M8
See #8209

@scabug scabug closed this as completed Feb 27, 2014
@scabug
Copy link
Author

scabug commented Feb 27, 2014

@xeno-by said:
Test case that verifies the fix that's already there in RC1: scala/scala#3589

@scabug scabug added this to the 2.11.0-RC1 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants