New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option zip should return Option #8394
Comments
Imported From: https://issues.scala-lang.org/browse/SI-8394?orig=1 |
@gourlaysama said: If you look at the full signature in the Scaladoc for Option (expand the zip method in the doc and then expand the "fullSignature" section at the bottom), you will see that there are no Option type involved. And there cannot be since Option does not implement zip, Iterable does (and there is an implicit conversion from Option to Iterable). |
Markus Klink (justjoheinz) said: |
Naftoli Gugenheim (naftoligug) said: |
Heikki Vesalainen (hvesalai) said: |
Mehmet Ali Gözaydın (kubudi) said: |
Vera Salvisberg (vsalvis) said (edited on Jun 4, 2015 9:40:02 AM UTC): |
@SethTisue said: but, I'm afraid the Scala team doesn't consider this issue addressable in 2.12, given our 2.12 compatibility promises; maybe for 2.13? see my comments at scala/scala#4836 (comment) |
@SethTisue said (edited on Oct 13, 2016 5:38:29 AM UTC): |
Heikki Vesalainen (hvesalai) said: |
Fixing this would take marshaling the Is this a good first issue? |
Dale isn't working on scala/scala#6491 anymore, he says. Would someone else like to take it? I've removed "good first issue" since there is now enough accumulated history and discussion on this to be potentially intimidating to a newcomer. Regardless, it's not a big change and shouldn't be hard for someone to pick up, assuming there aren't new objections to what seems to me (knock on wood) like emerging consensus on the PR about what the right design is. |
(And I've redone the labels to show that this is now about changing |
scala/scala#6491 seems to be moving again |
zip in the Option docs says:
zip[B](that: GenIterable[B]): Option[(A, B)]
but it acutally returns an Iterable[A, B]. I don't think it's a documentation bug, as returning an Option would make sense.
The text was updated successfully, but these errors were encountered: