Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of implicits in file matters; could we at least fix this for implicit objects? #8697

Open
scabug opened this issue Jun 30, 2014 · 4 comments
Labels
fixed in Scala 3 This issue does not exist in the Scala 3 compiler (https://github.com/lampepfl/dotty/) implicit infer
Milestone

Comments

@scabug
Copy link

scabug commented Jun 30, 2014

The following works:

trait T[_]
sealed trait A
sealed trait C


object A {
  implicit object AA extends T[A]
}

object C {
  implicit object CC extends T[C]
}

object B {
  implicitly[T[A]]
  implicitly[T[C]]
}

While the the following can not find the implicit T[C] instance:

trait T[_]
sealed trait A
sealed trait C


object A {
  implicit object AA extends T[A]
}

object B {
  implicitly[T[A]]
  implicitly[T[C]]
}

object C {
  implicit object CC extends T[C]
}

The only difference is the order of appearance for the B and C objects.

@scabug
Copy link
Author

scabug commented Jun 30, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8697?orig=1
Reporter: @puffnfresh
Affected Versions: 2.10.4, 2.11.1
See #3466

@scabug
Copy link
Author

scabug commented Jun 30, 2014

@retronym said:
Implicit objects are the same as implicit vals without explicit type annotations. We don't know there type without typechecking there body.

Implicit search will never force inference of an implicit down lower in the same file as the implicit call site. This avoids spurious cycles in inference.

Dotty, Martin's current research compiler, actually requires implicits to have explicit return types. IIRC, he does allow implicit objects. I'm not sure how he avoids the potential cycles.

I'll use this ticket as a reminder to dig into his approach and see if we can backport the treatment of implicit objects to Scala 2.12.

You can use explicitly type annotated implicit lazy vals as a more reliable tool.

@scabug
Copy link
Author

scabug commented Jun 30, 2014

@puffnfresh said:
@retronym thank you. That's a big help. I've been meaning to add lack of explicit types as a wart:

wartremover/wartremover#105

@scabug
Copy link
Author

scabug commented Mar 15, 2016

@SethTisue said:
there are a lot of tickets in this general space; see e.g. the links at #9674, #3466, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in Scala 3 This issue does not exist in the Scala 3 compiler (https://github.com/lampepfl/dotty/) implicit infer
Projects
None yet
Development

No branches or pull requests

4 participants