Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala version's unparse is unsightly #8711

Closed
scabug opened this issue Jul 9, 2014 · 5 comments
Closed

Scala version's unparse is unsightly #8711

scabug opened this issue Jul 9, 2014 · 5 comments
Assignees
@gourlaysama
Labels
has PR
Milestone
2.11.5

Comments

@scabug
Copy link

scabug commented Jul 9, 2014 •
edited by retronym

The current Implementation of nsc.tools.settings.ScalaVersion's unparse uses dots as a separator, whether there is something interesting to separate or not.

It makes Iulian's eyes bleed.

EDIT: Version numbers like 2.11.2.-20140706-234733-75ac225015
@scabug
Copy link
Author

scabug commented Jul 9, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8711?orig=1
Reporter: @huitseeker
Affected Versions: 2.11.2

@scabug
Copy link
Author

scabug commented Oct 10, 2014

@gourlaysama said:
I got bitten by this too. ScalaVersion should at least be consistent:

scala> ScalaVersion(ScalaVersion("2.11.3").unparse)
java.lang.NumberFormatException: There was a problem parsing 2.11.3.. Versions should be in the form major[.minor[.revision]] where each part is a positive number, as in 2.10.1. The minor and revision parts are optional.
  at scala.tools.nsc.settings.ScalaVersion$$anonfun$apply$1.apply(ScalaVersion.scala:114)
  at scala.tools.nsc.settings.ScalaVersion$$anonfun$apply$1.apply(ScalaVersion.scala:114)
  at scala.tools.nsc.settings.ScalaVersion$.errorAndValue$1(ScalaVersion.scala:78)
  at scala.tools.nsc.settings.ScalaVersion$.apply(ScalaVersion.scala:109)
  at scala.tools.nsc.settings.ScalaVersion$.apply(ScalaVersion.scala:114)
  ... 33 elided

@scabug
Copy link
Author

scabug commented Oct 10, 2014

@gourlaysama said:
scala/scala#4046

@scabug
Copy link
Author

scabug commented Nov 4, 2014

@retronym said:
Reassinging to 2.11.5, 2.11.4 has already been released.

@scabug scabug closed this as completed Nov 4, 2014
@scabug
Copy link
Author

scabug commented Feb 20, 2015

Tony Reix (trex58) said:
What is the status of this ?
I've downloaded several versions of Scala and I always have this issue.

@scabug scabug added this to the 2.11.5 milestone Apr 7, 2017
@scabug scabug mentioned this issue Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gourlaysama gourlaysama

Labels
has PR
Projects
None yet
Milestone
2.11.5
Development

No branches or pull requests
2 participants
@gourlaysama @scabug