New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use logger in the scala presentation compiler #8717
Comments
Imported From: https://issues.scala-lang.org/browse/SI-8717?orig=1 |
@adriaanm said: |
Samuel Halliday (fommil) said: However, if you don't want to use JUL then at least removing the @inline and allowing these methods to be overridden should be good enough. BTW I think there is some bug in the way the @inline methods are being interpreted. Even when my debug/verbose boolean vals are false (and I can check this), I still see some debug/verbose statements coming through on the terminal. It is just really really weird. |
@dragos said: @adriaanm, can you elaborate why Java logging isn't an option? If we go for overridable methods we still need to make them "not inline", which may or may not hurt performance. I don't know what the current optimizer can do, but at some point in the past, @inline log saved about 8% in code size and a couple of percentages in speed. It may not be an issue in 2.12 and Java 8 lambdas, but I think any fix should be backported to 2.11 too. |
Scala IDE is dead and the old ENSIME is too, so I'm guessing there's probably no longer downstream appetite for this? |
Currently, the Global uses a bunch of boolean settings to decide whether to log messages... but it uses println which is a real pain when used by downstream libraries (e.g. scala-ide and ENSIME). We can't filter any of the messages or re-direct them except with a big on/off button. Also, there are a bunch of messages that just can't be turned off at all and it look really weird to our users when we are trying to capture the stdout for meaningful debugging information.
Please, please, consider using a logger (J2SE has the JUL, which can easily be redirected with SLF4J by downstream users like me) instead of println.... or at the very least take in a Writer for debug/verbose/whatever levels.
The text was updated successfully, but these errors were encountered: