Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CannotHaveAttrs no longer throws IAE, failing the test #8816

Open
scabug opened this issue Aug 24, 2014 · 3 comments
Open

CannotHaveAttrs no longer throws IAE, failing the test #8816

scabug opened this issue Aug 24, 2014 · 3 comments
Labels
reflection
Milestone
Backlog

Comments

@scabug
Copy link

scabug commented Aug 24, 2014

scala/scala@5439c4c introduced an IllegalArgumentException for CannotHaveAttrs, and a test (assertThrows).

scala/scala@351a3e0d changed the exception to a log, without changing the test.

This went unnoticed because of a bug in assertThrows: if the expression does not throw at all, it would pass.

See here for the fix in assertThrows, it's not yet merged, but under review: lrytz/scala@3fea08e
@scabug
Copy link
Author

scabug commented Aug 24, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8816?orig=1
Reporter: @lrytz

@SethTisue SethTisue added this to the Backlog milestone Mar 1, 2018
@SethTisue
Copy link
Member

@lrytz still applicable?

@lrytz
Copy link
Member

lrytz commented Mar 2, 2018 •
edited

Yes, the tests are marked @Ignore https://github.com/scala/scala/blob/v2.13.0-M3/test/junit/scala/tools/nsc/symtab/CannotHaveAttrsTest.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reflection
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@lrytz @SethTisue @densh @scabug