Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emitting advice that compiles #9908

Closed
scabug opened this issue Aug 30, 2016 · 2 comments
Closed

Emitting advice that compiles #9908

scabug opened this issue Aug 30, 2016 · 2 comments
Assignees
@hrhino
Labels
enhancement errors and warnings has PR usability
Milestone
2.12.11

Comments

@scabug
Copy link

scabug commented Aug 30, 2016

It would be nice if it were easy for the compiler to emit snippets that necessarily compiled.

[error] /** As seen from class string is option name, the missing signatures are as follows.
[error]  *  For convenience, these are usable as stub implementations.
[error]  */
[error]   def --?: Boolean = ???

Whatever the word is for the syntactic category of colon, the advice should compile.
@scabug
Copy link
Author

scabug commented Aug 30, 2016

Imported From: https://issues.scala-lang.org/browse/SI-9908?orig=1
Reporter: @som-snytt

@scabug scabug added this to the Backlog milestone Apr 7, 2017
hrhino added a commit to hrhino/scala that referenced this issue Feb 29, 2020
@hrhino
Emit advice that compiles
66c5aba 
Like it asks for on the ticket. Presumably there's a lot more advice
that doesn't compile, such as scala/bug#11301, but here's a step forward.

Fixes scala/bug#9908.
@hrhino hrhino mentioned this issue Feb 29, 2020
Merged
@hrhino hrhino modified the milestones: Backlog, 2.12.12 Feb 29, 2020
@hrhino hrhino added the has PR label Feb 29, 2020
@hrhino hrhino self-assigned this Feb 29, 2020
hrhino added a commit to hrhino/scala that referenced this issue Feb 29, 2020
@hrhino
Emit advice that compiles
6c9e985 
Like it asks for on the ticket. Presumably there's a lot more advice
that doesn't compile, such as scala/bug#11301, but here's a step forward.

Fixes scala/bug#9908.
hrhino added a commit to hrhino/scala that referenced this issue Mar 1, 2020
@hrhino
Emit advice that compiles
f057651 
Like it asks for on the ticket. Presumably there's a lot more advice
that doesn't compile, such as scala/bug#11301, but here's a step forward.

Fixes scala/bug#9908.

Tweaked, reformatted, and generally
Co-Authored-By: "Som Snytt" <som.snytt@gmail.com
hrhino added a commit to hrhino/scala that referenced this issue Mar 1, 2020
@hrhino
Emit advice that compiles
4cf3f02 
Like it asks for on the ticket. Presumably there's a lot more advice
that doesn't compile, such as scala/bug#11301, but here's a step forward.

Fixes scala/bug#9908.

Tweaked, reformatted, and generally

Co-Authored-By: "Som Snytt" <som.snytt@gmail.com
hrhino added a commit to hrhino/scala that referenced this issue Mar 1, 2020
@hrhino
Emit advice that compiles
a8f7289 
Like it asks for on the ticket. Presumably there's a lot more advice
that doesn't compile, such as scala/bug#11301, but here's a step forward.

Fixes scala/bug#9908.

Tweaked, reformatted, and generally
Co-Authored-By: "Som Snytt" <som.snytt@gmail.com>
hrhino added a commit to hrhino/scala that referenced this issue Mar 1, 2020
@hrhino @som-snytt
Emit advice that compiles
5525100 
Like it asks for on the ticket. Presumably there's a lot more advice
that doesn't compile, such as scala/bug#11301, but here's a step forward.

Fixes scala/bug#9908.

Tweaked, reformatted, and generally

Co-Authored-By: "Som Snytt" <som.snytt@gmail.com>
@lrytz lrytz modified the milestones: 2.12.12, 2.12.11 Mar 2, 2020
@lrytz lrytz closed this as completed Mar 2, 2020
@lrytz
Copy link
Member

lrytz commented Mar 2, 2020

scala/scala#8770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrhino hrhino

Labels
enhancement errors and warnings has PR usability
Projects
None yet
Milestone
2.12.11
Development

No branches or pull requests
4 participants
@lrytz @SethTisue @scabug @hrhino