Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid tail-calls in t6308 when inspecting stack, those stack frames can get elided on Avian #7599

Closed
scabug opened this issue Jun 23, 2013 · 2 comments
Closed

Avoid tail-calls in t6308 when inspecting stack, those stack frames can get elided on Avian #7599

scabug opened this issue Jun 23, 2013 · 2 comments
Assignees
@soc
Milestone
2.11.0-M4

Comments

@scabug
Copy link

scabug commented Jun 23, 2013

The test in t6308 inspects the names in a stacktrace to determine whether the right methods have been called.

This might break on Avian with tail call optimization enabled, because the stackframe in question could have been elided.

The easiest fix is to convert the method in question into a non-tail-callable method.
@scabug
Copy link
Author

scabug commented Jun 23, 2013

Imported From: https://issues.scala-lang.org/browse/SI-7599?orig=1
Reporter: @soc
Affected Versions: 2.11.0-M3

@scabug
Copy link
Author

scabug commented Jun 23, 2013

@soc said:
scala/scala#2675

@scabug scabug closed this as completed Jun 26, 2013
@scabug scabug added this to the 2.11.0-M4 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soc soc

Labels
None yet
Projects
None yet
Milestone
2.11.0-M4
Development

No branches or pull requests
2 participants
@soc @scabug