Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclic chain of originals in MacroExpansionAttachment #8486

Closed
scabug opened this issue Apr 8, 2014 · 6 comments
Closed

cyclic chain of originals in MacroExpansionAttachment #8486

scabug opened this issue Apr 8, 2014 · 6 comments
Labels
Milestone

Comments

@scabug
Copy link

scabug commented Apr 8, 2014

Looks like under some conditions, MacroExpansionAttachment can short-circuit, zapping unaware macro explorers: sbt/sbt#1237.

@scabug
Copy link
Author

scabug commented Apr 8, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8486?orig=1
Reporter: @xeno-by
Affected Versions: 2.11.0

@scabug
Copy link
Author

scabug commented Apr 8, 2014

@gkossakowski said:
I think I'd like to rise priority to Critical for this one. It might require rather ugly work-arounds in sbt code which is very hot. I'd prefer to not complicate logic in hot places for performance reasons.

@scabug
Copy link
Author

scabug commented Apr 8, 2014

@xeno-by said:
You mean you'd like to have this fixed in 2.11.0-final or 2.11.1 would be enough?

@scabug
Copy link
Author

scabug commented Apr 8, 2014

@gkossakowski said:
I don't think it's a blocker for 2.11.0 release.

In 2.11.1 should be enough. Actually, given the fact I realized it's not that bad for performance then keeping it Major should be ok. However, this original field is quite important to tools like IDE so we should fix it eventually.

@scabug
Copy link
Author

scabug commented Nov 3, 2015

@adriaanm said:
Looks like this was fixed on the sbt side? Can you still repro with sbt 0.13.8?

Here are some of the PRs that seem to fix this issue:
sbt/sbt#1237
sbt/sbt#1408
sbt/sbt#1563
sbt/sbt#1642

@scabug scabug added the macros label Apr 7, 2017
@scabug scabug added this to the Backlog milestone Apr 7, 2017
@SethTisue
Copy link
Member

presuming fixed, since no one has said otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants