New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some tests fail on Windows if source files are checked out with CRLF line endings #9472
Comments
Imported From: https://issues.scala-lang.org/browse/SI-9472?orig=1 |
@SethTisue said: |
@retronym said:
Nitpick: they should checkout with unaltered line endings. Some files in our repo have CRLF line endings:
|
@som-snytt said:
to help mitigate one form of mixed line endings. |
@martijnhoekstra said: Currently it has
which will set all files to auto text, meaning on check out it converts all line endings to core.eol, and on check in convert all line endings to lf. For anyone who has core.eol set to anything but lf that would spell trouble. I'm no git wizard, but shouldn't changing that line to
do the trick? If it does, it seems like a better solution than to tell all windows users to config their core.eol for this repo. In response to Jasons nitpick: The *-windows.tmpl files (as well as .cmd and .bat) are already set to eol=crlf in .gitattributes |
@SethTisue said (edited on Sep 17, 2015 11:57:56 AM UTC): |
@SethTisue said: |
@SethTisue said: |
@SethTisue said: |
Because of #3101, some triple-quoted strings in the source code for Scala have different line endings depending on how the source files are checked out of version control. This then causes failures because the additional CR characters cause (e.g.) String.equals or String.contains checks to fail.
Affected files include:
The text was updated successfully, but these errors were encountered: