Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The fix for SI-7898 broke the REPL when using sbt #9804

Closed
scabug opened this issue Jun 4, 2016 · 5 comments
Closed

The fix for SI-7898 broke the REPL when using sbt #9804

scabug opened this issue Jun 4, 2016 · 5 comments
Assignees
@som-snytt
Labels
blocker repl
Milestone
2.11.11

Comments

@scabug
Copy link

scabug commented Jun 4, 2016

Using the current HEAD of 2.12.x (af93c7a147156f69cad78cc80a36aeaeb89cbe0c) after the first expression, the REPL is broken - you can't see what you type:

Welcome to Scala 2.11.9-20160520-170134-99dad60 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_74).
Type in expressions for evaluation. Or try :help.

scala> 1
res0: Int = 1

scala> res1: Int = 2

scala> res2: Int = 3

scala> res3: Int = 3

I've bisected it to scala/scala@99dad60, which is part of scala/scala#4998

Note that that pull request was made against 2.11.x, so it's also broken there (there's no 2.11.x in "Affects Version/s"..)

/cc @som-snytt
@scabug
Copy link
Author

scabug commented Jun 4, 2016

Imported From: https://issues.scala-lang.org/browse/SI-9804?orig=1
Reporter: @dwijnand
Affected Versions: 2.11.9, 2.12.1
Other Milestones: 2.12.0-M5
See #7898

@scabug
Copy link
Author

scabug commented Jun 4, 2016

@adriaanm said:
Thanks for the report & diagnosis, Dale! We should fix this or revert the change before we cut M5 (next week).

@scabug
Copy link
Author

scabug commented Jun 4, 2016

@som-snytt said:
Also, on ctl-D

scala> <console>:1: error: illegal character '\u0004'
\u0004
^

@scabug
Copy link
Author

scabug commented Jun 4, 2016

@dwijnand said:
Also, this isn't broken in the custom scala task (in scala/scala's sbt build), nor is it in build/quick/bin/scala, it's something in that change that clashes with how sbt setups or invokes the REPL.

@scabug
Copy link
Author

scabug commented Jun 4, 2016

@som-snytt said (edited on Jun 4, 2016 10:53:55 PM UTC):
scala/scala#5214

against 2.11, which must be merged forward for 2.12.

Somebody ought to update SBT not to use API deprecated since 2.9.0. That would make it easier to control these extension points.

In older code, the reader set by SBT was immediately overwritten; in the newer code, the reader was initialized before the call to createInterpreter, which SBT overrides (and in which SBT sets its own reader).

@scabug scabug closed this as completed Jun 14, 2016
@scabug scabug added this to the 2.11.9 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@som-snytt som-snytt

Labels
blocker repl
Projects
None yet
Milestone
2.11.11
Development

No branches or pull requests
2 participants
@som-snytt @scabug